Skip to content

[dotnet][rb][java][js][py] Automated Browser Version Update #14703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

[dotnet][rb][java][js][py] Automated Browser Version Update #14703

merged 1 commit into from
Nov 11, 2024

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Nov 2, 2024 •
edited
Loading

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 2, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Compatibility
Ensure that the updated browser versions (Firefox 133.0b3 and Edge 130.0.2849.71) are compatible with the existing codebase and don't introduce any breaking changes.

Checksum Verification
Verify that the new SHA256 checksums for Firefox and Edge driver downloads are correct and match the official releases.

Platform Consistency
Check if the updates for Firefox and Edge drivers are consistent across all supported platforms (Linux, Mac, Windows if applicable).

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 2, 2024

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Maintainability
Use variables for version numbers and checksums to improve maintainability and consistency

Consider using variables for version numbers and SHA256 checksums to improve
maintainability and reduce the risk of inconsistencies when updating multiple
instances.

common/repositories.bzl [51-56]

+FIREFOX_BETA_VERSION = "133.0b3"
+FIREFOX_LINUX_SHA256 = "9a2c472c25984bb47b3b829120e44333feb15a5c34fb5552036bf3cb1b44b442"
+
 http_archive(
     name = "linux_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/133.0b3/linux-x86_64/en-US/firefox-133.0b3.tar.bz2",
-    sha256 = "9a2c472c25984bb47b3b829120e44333feb15a5c34fb5552036bf3cb1b44b442",
+    url = f"https://ftp.mozilla.org/pub/firefox/releases/{FIREFOX_BETA_VERSION}/linux-x86_64/en-US/firefox-{FIREFOX_BETA_VERSION}.tar.bz2",
+    sha256 = FIREFOX_LINUX_SHA256,
     build_file_content = """
  • Apply this suggestion
Suggestion importance[1-10]: 8

Why: This suggestion improves maintainability by using variables for version numbers and checksums, reducing the risk of inconsistencies and making future updates easier. It directly addresses the repetitive nature of the code and enhances its clarity.

8

💡 Need additional feedback ? start a PR chat

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch 4 times, most recently from 3ab3531 to 1e47952 Compare November 6, 2024 00:36
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 6, 2024 •
edited
Loading

CI Failure Feedback 🧐

(Checks updated until commit 0f5784a)

Action: Ruby / Local Tests (firefox, macos) / Local Tests (firefox, macos)

Failed stage: Run Bazel [❌]

Failed test name: //rb/spec/integration/selenium/webdriver:action_builder-firefox

Failure summary:

The action failed due to a missing library dependency required for executing a script:

  • The cdp-generate.sh script failed to execute because it could not load the libgmp.10.dylib library.
  • The error message indicates that the library was not found in the expected directories.
  • This missing library caused the build process to abort, resulting in a failure to build the target
    //rb/lib/selenium/devtools:cdp-v130.
  • Consequently, 1 test failed to build, and 27 tests were skipped.

    • Relevant error logs: 
    1:  ##[group]Operating System
2:  macOS
...

651:  �[32m[1,087 / 1,882]�[0m Executing genrule //common/devtools/chromium/v128:browser_protocol; 3s darwin-sandbox, disk-cache ... (3 actions, 2 running)
652:  �[32m[1,111 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 1s disk-cache, multiplex-worker ... (3 actions running)
653:  �[32m[1,112 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 2s disk-cache, multiplex-worker ... (3 actions, 2 running)
654:  �[32m[1,115 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 3s disk-cache, multiplex-worker ... (3 actions running)
655:  �[32m[1,116 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 4s disk-cache, multiplex-worker ... (3 actions running)
656:  �[32m[1,120 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 5s disk-cache, multiplex-worker ... (3 actions running)
657:  �[32m[1,123 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 6s disk-cache, multiplex-worker ... (3 actions running)
658:  �[32m[1,124 / 1,882]�[0m Building external/protobuf~/java/core/libcore.jar (36 source files, 1 source jar) [for tool]; 7s disk-cache, multiplex-worker ... (3 actions, 2 running)
659:  �[31m�[1mERROR: �[0m/Users/runner/work/selenium/selenium/rb/lib/selenium/devtools/BUILD.bazel:35:15: RunBinary rb/lib/selenium/devtools/v130.rb failed: (Aborted): cdp-generate.sh failed: error executing RunBinary command (from target //rb/lib/selenium/devtools:cdp-v130) 
...

663:  PATH=/bin:/usr/bin:/usr/local/bin \
664:  bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/rb/lib/selenium/devtools/cdp-generate.sh bazel-out/darwin_arm64-fastbuild/bin/common/devtools/chromium/v130/browser_protocol.json bazel-out/darwin_arm64-fastbuild/bin/common/devtools/chromium/v130/js_protocol.json bazel-out/darwin_arm64-fastbuild/bin/rb/lib/selenium/devtools/v130.rb v130)
665:  # Configuration: 8800e9f0e09a88a93111146a2ee133974b205d6193f344466d9a059be4a8de9c
666:  # Execution platform: @@platforms//host:host
667:  Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
668:  dyld[4553]: Library not loaded: /usr/local/opt/gmp/lib/libgmp.10.dylib
669:  Referenced from: <E2FA1E00-9242-39F3-98BE-144E136AFFE8> /Users/runner/.bazel/external/rules_ruby~~ruby~ruby/dist/bin/ruby
670:  Reason: tried: '/usr/local/opt/gmp/lib/libgmp.10.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/opt/gmp/lib/libgmp.10.dylib' (no such file), '/usr/local/opt/gmp/lib/libgmp.10.dylib' (no such file)
671:  �[32m[1,127 / 1,882]�[0m 1 / 28 tests, �[31m�[1m1 failed�[0m;�[0m checking cached actions
672:  �[32mINFO: �[0mElapsed time: 78.560s, Critical Path: 9.98s
673:  �[32mINFO: �[0m1127 processes: 239 disk cache hit, 876 internal, 9 darwin-sandbox, 3 worker.
674:  //rb/spec/integration/selenium/webdriver:bidi-firefox                 �[0m�[31m�[1mNO STATUS�[0m
675:  �[31m�[1mERROR: �[0mBuild did NOT complete successfully
676:  //rb/spec/integration/selenium/webdriver:devtools-firefox             �[0m�[31m�[1mNO STATUS�[0m
677:  //rb/spec/integration/selenium/webdriver:driver-firefox               �[0m�[31m�[1mNO STATUS�[0m
678:  //rb/spec/integration/selenium/webdriver:element-firefox              �[0m�[31m�[1mNO STATUS�[0m
679:  //rb/spec/integration/selenium/webdriver:error-firefox                �[0m�[31m�[1mNO STATUS�[0m
...

695:  //rb/spec/integration/selenium/webdriver/bidi:browsing_context-firefox �[0m�[31m�[1mNO STATUS�[0m
696:  //rb/spec/integration/selenium/webdriver/bidi:log_inspector-firefox   �[0m�[31m�[1mNO STATUS�[0m
697:  //rb/spec/integration/selenium/webdriver/bidi:script-firefox          �[0m�[31m�[1mNO STATUS�[0m
698:  //rb/spec/integration/selenium/webdriver/firefox:driver-firefox       �[0m�[31m�[1mNO STATUS�[0m
699:  //rb/spec/integration/selenium/webdriver/firefox:profile-firefox      �[0m�[31m�[1mNO STATUS�[0m
700:  //rb/spec/integration/selenium/webdriver/firefox:service-firefox      �[0m�[31m�[1mNO STATUS�[0m
701:  //rb/spec/integration/selenium/webdriver/remote:driver-firefox        �[0m�[31m�[1mNO STATUS�[0m
702:  //rb/spec/integration/selenium/webdriver/remote:element-firefox       �[0m�[31m�[1mNO STATUS�[0m
703:  //rb/spec/integration/selenium/webdriver:action_builder-firefox �[0m�[31m�[1mFAILED TO BUILD�[0m
704:  Executed 0 out of 28 tests: �[0m�[31m�[1m1 fails to build�[0m and �[0m�[35m27 were skipped�[0m.
705:  ##[error]Process completed with exit code 1.
    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @selenium-ci selenium-ci force-pushed the pinned-browser-updates branch 4 times, most recently from ffd9a75 to c508fba Compare November 10, 2024 00:39
    @selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from c508fba to 0f5784a Compare November 11, 2024 00:38
    @VietND96 VietND96 merged commit 6f99c70 into trunk Nov 11, 2024
    29 of 32 checks passed
    @VietND96 VietND96 deleted the pinned-browser-updates branch November 11, 2024 03:57
    jkim2492 pushed a commit to jkim2492/selenium that referenced this pull request Nov 17, 2024
    @selenium-ci @jkim2492
    [dotnet][rb][java][js][py] Automated Browser Version Update (Selenium…
    a6a405e 
    …HQ#14703)

Update pinned browser versions

Co-authored-by: Selenium CI Bot <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @selenium-ci @VietND96